[PATCH] D77874: [AArch32] Armv8.6a Matrix Mul Assembly

[Luke Geeson via Phabricator via llvm-commits]

LukeGeeson added a comment.

In D77874#1991735 <https://reviews.llvm.org/D77874#1991735>, @simon_tatham wrote:

> The important part of this patch seems to be missing! It says it's adding AArch32 assembly parsing for some new instructions, but I don't see any new Tablegen work that adds the instructions. New mnemonics are added to a couple of exclusion lists in ARMAsmParser, but there's no code in here that makes the mnemonics actually //exist// in the first place, or that says what their operands should be or what their encodings are – just that small C++ tweak and a load of tests. Where's the rest of it?


Apologies, I submitted multiple patches for review at once. The assembly support is ready to land and is found in [1], so I suppose I should rename this patch to "AArch32 Assembly Parser Support" or some variant thereof. What do you think?

[1] https://reviews.llvm.org/D77872


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77874/new/

https://reviews.llvm.org/D77874