[PATCH] D77874: [AArch32] Armv8.6a Matrix Mul Assembly

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 20 01:02:30 PDT 2020


simon_tatham added a comment.

The important part of this patch seems to be missing! It says it's adding AArch32 assembly parsing for some new instructions, but I don't see any new Tablegen work that adds the instructions. New mnemonics are added to a couple of exclusion lists in ARMAsmParser, but there's no code in here that makes the mnemonics actually //exist// in the first place, or that says what their operands should be or what their encodings are – just that small C++ tweak and a load of tests. Where's the rest of it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77874/new/

https://reviews.llvm.org/D77874





More information about the llvm-commits mailing list