[PATCH] D74651: Add IR constructs for inalloca replacement llvm.call.setup

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D74651#1987461 <https://reviews.llvm.org/D74651#1987461>, @dexonsmith wrote:

> In D74651#1987364 <https://reviews.llvm.org/D74651#1987364>, @rnk wrote:
>
> > In D74651#1987254 <https://reviews.llvm.org/D74651#1987254>, @aeubanks wrote:
> >
> > > Does the LangRef patch typically come before, after, or in the same commit? After doing some experimenting?
> >
> >
> > I guess in this case it would be best to put together a LangRef patch to land before this one, in case anyone wants to look at it alone, without the boilerplate.
>
>
> A nice feature of landing LangRef changes coincidentally with IR changes is having the documentation at https://www.llvm.org/docs/LangRef.html match the code in https://github.com/llvm/llvm-project.  But if there's a good reason to split them up I agree with @rnk that "docs before" is the right order.


I added the LangRef change to this change, it shouldn't be too hard to just look at the LangRef changes.
(also, how do you look at the rendered version before submitting?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651