[PATCH] D74651: Add IR constructs for inalloca replacement llvm.call.setup

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 17 15:11:08 PDT 2020


aeubanks added a comment.

In D74651#1987364 <https://reviews.llvm.org/D74651#1987364>, @rnk wrote:

> In D74651#1987254 <https://reviews.llvm.org/D74651#1987254>, @aeubanks wrote:
>
> > I like adding `preallocated` to the intrinsic name, but I think we should do it for all the intrinsics, especially since the `@llvm.call` prefix seems fairly generic.
> >  Do `@llvm.call.preallocated.setup`, `@llvm.call.preallocated.arg`, and `@llvm.call.preallocated.teardown` sound good?
>
>
> I like that nomenclature. The the whole feature can be referred to as "calls with preallocated argument memory" or "preallocated call sites", and it sounds like grammatically correct English.


I renamed the "callsetup" operand bundle to "preallocated" because of this, lmk if that's too confusing since the attribute is also called "preallocated".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74651/new/

https://reviews.llvm.org/D74651





More information about the llvm-commits mailing list