[PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED

[Aaron Ballman via llvm-commits]

On Fri, Apr 17, 2020 at 11:59 AM David Truby <David.Truby at arm.com> wrote:
>
> Hi Aaron,
>
> I believe it's the users choice when creating the revision who it is editable by, perhaps Mehdi doesn't know the etiquette of this on Phabricator?
>
> The etiquette in LLVM is to allow anyone to edit the revision so that they can add themselves as a reviewer if they wish to; Mehdi would you be able to leave the edit permissions on "All users" in future please?

Ah, I didn't know this was a per-review choice. I think we do not want
the (default) behavior of code reviews to limit who is allowed to
comment on the review. Thanks for the explanation!

~Aaron

>
> Thanks!
> David Truby
>
>
> From: Aaron Ballman <aaron at aaronballman.com>
> Date: Fri, 17 Apr 2020 at 16:44
> Subject: Re: [PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED
> To: <reviews+D78356+public+35a70e8ed1a03219 at reviews.llvm.org>, David Truby via Phabricator <reviews at reviews.llvm.org>
> Cc: <psteinfeld at nvidia.com>, <vjayathirtha at nvidia.com>, <tkeith at nvidia.com>, <sscalpone at nvidia.com>, <aperry at lanl.gov>, <kiranchandramohan at gmail.com>, <david.truby at gmail.com>, <jperier at nvidia.com>, <clementval at gmail.com>, <eric.schweitz at pgroup.com>, <v.churavy at gmail.com>, <isuruf at gmail.com>, Johannes Doerfert <jdoerfert at anl.gov>, llvm-commits <llvm-commits at lists.llvm.org>
>
>
> I think there's a Phab configuration error because I'm unable to leave
> this feedback on the review itself. Adding the comment and pressing
> the Submit button gives me:
>
> You Shall Not Pass: D78356
>
> You do not have permission to edit this object.
> Users with the "Can Edit" capability:
>
> Members of the project "Flang" can take this action.
> The owner of a revision can always view and edit it.
>
> Can one of the flang maintainers please look into correcting that?
>
> The review feedback I was attempting to leave is: Is there a reason to
> not use LLVM_ATTRIBUTE_UNUSED from Compiler.h? (Sorry if this is a
> dumb drive-by question.)
>
> Thanks!
>
> ~Aaron
>
> On Fri, Apr 17, 2020 at 11:37 AM David Truby via Phabricator via
> llvm-commits <llvm-commits at lists.llvm.org> wrote:
> >
> > DavidTruby accepted this revision.
> > DavidTruby added a comment.
> >
> > LGTM: We should probably remove this macro and use [[maybe_unused]] directly since it's standard, but I think we can merge this in the mean time to fix MSVC.