[PATCH] D78356: [flang] Use a better definition for ATTRIBUTE_UNUSED

[Aaron Ballman via llvm-commits]

I think there's a Phab configuration error because I'm unable to leave
this feedback on the review itself. Adding the comment and pressing
the Submit button gives me:

You Shall Not Pass: D78356

You do not have permission to edit this object.
Users with the "Can Edit" capability:

Members of the project "Flang" can take this action.
The owner of a revision can always view and edit it.

Can one of the flang maintainers please look into correcting that?

The review feedback I was attempting to leave is: Is there a reason to
not use LLVM_ATTRIBUTE_UNUSED from Compiler.h? (Sorry if this is a
dumb drive-by question.)

Thanks!

~Aaron

On Fri, Apr 17, 2020 at 11:37 AM David Truby via Phabricator via
llvm-commits <llvm-commits at lists.llvm.org> wrote:
>
> DavidTruby accepted this revision.
> DavidTruby added a comment.
>
> LGTM: We should probably remove this macro and use [[maybe_unused]] directly since it's standard, but I think we can merge this in the mean time to fix MSVC.