[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked an inline comment as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1712
-  // eventually.
-  const auto *GV = dyn_cast<const GlobalVariable>(GO);
-  if (GV) {
----------------
daltenty wrote:
> Does it matter we're losing this early error check? Will we end up creating symbols for unanticipated GV kinds before we hit the corresponding check in emitGlobalVariable (and do we care)?
I think it's possible for us to create symbols for unanticpated GV kinds, but it will get caught in emitGlobalVariable if we don't do it in `getTargetSymbol`. I think it should be Okay if we could eventually catch it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045