[PATCH] D78045: [XCOFF][AIX] Fix getSymbol to return the correct qualname when necessary

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 13:31:14 PDT 2020


hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:1883
+MCSymbol *
+TargetLoweringObjectFileXCOFF::getTargetSymbol(const GlobalValue *GV,
+                                               const TargetMachine &TM) const {
----------------
I understand the current caller does not have the necessary context, but target symbols for XCOFF are not limited to the csect versus label that this currently handles. It extends to function descriptor versus entry point.

Can we use an expanded version of this function to common up the entry point referencing between `AsmPrinter::SetupMachineFunction` and the `transformCallee` that is used by `PPCTargetLowering::FinishCall`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78045/new/

https://reviews.llvm.org/D78045





More information about the llvm-commits mailing list