[PATCH] D78072: [lld][WebAssembly] Do not require --shared-memory with --relocatable

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 14:05:03 PDT 2020


tlively marked an inline comment as done.
tlively added inline comments.


================
Comment at: lld/wasm/Writer.cpp:425
+  if (allowed.count("atomics") && !config->sharedMemory &&
+      !config->relocatable) {
     if (inferFeatures)
----------------
sbc100 wrote:
> Somehow this condition makes more sense when I read it if the relocatable check comes first.  But maybe that just me ..
Sure, I'll swap it around.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78072/new/

https://reviews.llvm.org/D78072





More information about the llvm-commits mailing list