[PATCH] D78072: [lld][WebAssembly] Do not require --shared-memory with --relocatable

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 12:58:26 PDT 2020


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/wasm/Writer.cpp:425
+  if (allowed.count("atomics") && !config->sharedMemory &&
+      !config->relocatable) {
     if (inferFeatures)
----------------
Somehow this condition makes more sense when I read it if the relocatable check comes first.  But maybe that just me ..


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78072/new/

https://reviews.llvm.org/D78072





More information about the llvm-commits mailing list