[PATCH] D77986: [lit] Move llvm-test-suite result codes into llvm/lit

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 14 08:33:13 PDT 2020


jdenny added a comment.

> I don't think we should "rename" it in the test-suite as it is not "unresolved" (whatever that then means) but we just failed to produce an executable so the compile stage failed not the run stage (which would be FAIL).

Based on that description, I agree with @jdoerfert that UNRESOLVED or SKIPPED doesn't make sense for NOEXE.  NOEXE sounds like a special kind of FAIL.  I don't have enough experience with lnt to know why it's worthwhile to distinguish NOEXE from FAIL, but it's not a new distinction in lnt.  If it's worthwhile there, maybe it will be worthwhile in other lit-based test suites too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77986/new/

https://reviews.llvm.org/D77986





More information about the llvm-commits mailing list