[PATCH] D77986: [lit] Move llvm-test-suite result codes into llvm/lit

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D77986#1979080 <https://reviews.llvm.org/D77986#1979080>, @yln wrote:

> Ah okay, I didn't realize that `NOEXE` had nothing to do with lit's `--no-execute` option.  I think you can use UNRESOLVED instead of creating a specific category for it and use the already existing SKIPPED. Would that work?


I guess one could use UNRESOLVED but I'm unsure why and I think there are obvious drawbacks: It would introduce a weird split between the llvm-test-suite and llvm/lit as `NOEXE` in the former would then map to something else in the latter. I don't think we should "rename" it in the test-suite as it is not "unresolved" (whatever that then means) but we just failed to produce an executable so the compile stage failed not the run stage (which would be FAIL).

Using the SKIPPED category has similar problems (conceptually, I don't know if it would actually show right now):  We didn't skip the test, we compiled, failed to produce an executable, and consequently couldn't run anything. Skipped implies something else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77986/new/

https://reviews.llvm.org/D77986