[PATCH] D77578: [AIX][PPC] Implement caller byval arguments in stack memory

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval-mem.ll:56
+; 32BIT-DAG:   li 5, 256
+; 32BIT-NEXT:  bl .memcpy
+; 32BIT:       bl .test_byval_mem2
----------------
cebowleratibm wrote:
> sfertile wrote:
> > Missing the nop for toc-restore,  and loading of arguments for the call to `test_byval_mem2` for both 32-bit and 64-bit check directives.
> In an attempt to keep the CC tests shorter and more focussed I had opted to omit these and check only for the instuctions that set up the byval argument to the call.  If you feel strongly that these should be included in the check I can bring them back.
I think its important to show that the memcpy call happens completely outside the call sequence we are lowering since the call to memcpy that gets inserted would clobber the volatile registers we are using to pass the arguments. Its also worth it to show that the toc-restore nop gets emitted as that is part of the call sequence when the target is to an external function. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77578/new/

https://reviews.llvm.org/D77578