[PATCH] D77578: [AIX][PPC] Implement caller byval arguments in stack memory

[Chris Bowler via Phabricator via llvm-commits]

cebowleratibm added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval-mem.ll:56
+; 32BIT-DAG:   li 5, 256
+; 32BIT-NEXT:  bl .memcpy
+; 32BIT:       bl .test_byval_mem2
----------------
sfertile wrote:
> Missing the nop for toc-restore,  and loading of arguments for the call to `test_byval_mem2` for both 32-bit and 64-bit check directives.
In an attempt to keep the CC tests shorter and more focussed I had opted to omit these and check only for the instuctions that set up the byval argument to the call.  If you feel strongly that these should be included in the check I can bring them back.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-cc-byval-mem.ll:88
+; 32BIT-DAG:   li 5, 33
+; 32BIT-NEXT:  bl .memcpy
+; 32BIT-DAG:   lwz 5, 0([[REG]])
----------------
sfertile wrote:
> Check for the nop after the call to memcpy
Also omitted to reduce size.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77578/new/

https://reviews.llvm.org/D77578