[PATCH] D78078: [lit] Add FILTERED test result category

[Julian Lettner via Phabricator via llvm-commits]

yln marked 2 inline comments as done.
yln added inline comments.


================
Comment at: llvm/utils/lit/lit/main.py:60
 
+    determine_order(discovered_tests, opts.order)
+
----------------
Sort all discovered tests (not just the filtered ones) for consistency in test result output.  There is a test which covers this.


================
Comment at: llvm/utils/lit/lit/main.py:273
 all_codes = [
+    (lit.Test.FILTERED,    'Filtered Tests',    'Filtered'),
     (lit.Test.SKIPPED,     'Skipped Tests',     'Skipped'),
----------------
Should this be 'Filtered Out' instead?  I think 'Filtered' is clear in this context, but 'Filtered Out' would be "more correct".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78078/new/

https://reviews.llvm.org/D78078