[PATCH] D78078: [lit] Add FILTERED test result category

[Julian Lettner via Phabricator via llvm-commits]

yln created this revision.
yln added reviewers: rnk, jdenny, serge-sans-paille, probinson.
Herald added subscribers: llvm-commits, delcypher.
Herald added a project: LLVM.
yln marked 2 inline comments as done.
yln added inline comments.


================
Comment at: llvm/utils/lit/lit/main.py:60
 
+    determine_order(discovered_tests, opts.order)
+
----------------
Sort all discovered tests (not just the filtered ones) for consistency in test result output.  There is a test which covers this.


================
Comment at: llvm/utils/lit/lit/main.py:273
 all_codes = [
+    (lit.Test.FILTERED,    'Filtered Tests',    'Filtered'),
     (lit.Test.SKIPPED,     'Skipped Tests',     'Skipped'),
----------------
Should this be 'Filtered Out' instead?  I think 'Filtered' is clear in this context, but 'Filtered Out' would be "more correct".


Track and print the number of tests that were discovered but not
executed due to filtering options:

- --filter (regex filter)
- --max-tests (limits number of tests)
- sharding feature

With this change all discovered tests are accounted for: every
discovered test is included in one of the counts printed in the summary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D78078

Files:
  llvm/utils/lit/lit/Test.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/selecting.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78078.257189.patch
Type: text/x-patch
Size: 4247 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200414/c6d05a2c/attachment.bin>