[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

Brian Yang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 9 14:57:57 PDT 2020


ichoyjx added a comment.

In D77821#1972684 <https://reviews.llvm.org/D77821#1972684>, @jdoerfert wrote:

> Why is this not caught by the parser? I mean, this seems a lot of code to accommodate negative values and some conditions to not trip over them even though they are never allowed/useful.


The argument is only an Expr to the parser. To check whether it's an integer or constant, we need to do that in Semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821





More information about the llvm-commits mailing list