[PATCH] D77821: [Flang][OpenMP] Avoid abort when collapse clause value is negative

[Valentin Clement via Phabricator via llvm-commits]

clementval added a comment.

In D77821#1972684 <https://reviews.llvm.org/D77821#1972684>, @jdoerfert wrote:

> Why is this not caught by the parser? I mean, this seems a lot of code to accommodate negative values and some conditions to not trip over them even though they are never allowed/useful.


The parser doesn’t enforce any semantic checking or name resolution so any int expression is valid at parsing time.

In D77821#1972684 <https://reviews.llvm.org/D77821#1972684>, @jdoerfert wrote:

> Why is this not caught by the parser? I mean, this seems a lot of code to accommodate negative values and some conditions to not trip over them even though they are never allowed/useful.





Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77821/new/

https://reviews.llvm.org/D77821