[PATCH] D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1609
                 TM));
-  GVSym->setContainingCsect(Csect);
 
----------------
DiggerLin wrote:
> I think we still need GVSym->setContainingCsect(Csect) for extern variable . when we emitlLnkage for the extern Variable, the GVSym is not a qualName symbol,  So we get the SMC from GVSym's containningCsect.
> 
> for example:
> extern int b_e;
> we need to emit linkage as
> .extern  b_e[UA]
I think we can change to 
if ( GV->isDeclaration()) {
  GVSym->setContainingCsect(Csect);
}


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77080/new/

https://reviews.llvm.org/D77080