[PATCH] D77080: [NFC][XCOFF][AIX] Refactor get/setContainingCsect

Digger via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 31 10:00:15 PDT 2020


DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1609
                 TM));
-  GVSym->setContainingCsect(Csect);
 
----------------
I think we still need GVSym->setContainingCsect(Csect) for extern variable . when we emitlLnkage for the extern Variable, the GVSym is not a qualName symbol,  So we get the SMC from GVSym's containningCsect.

for example:
extern int b_e;
we need to emit linkage as
.extern  b_e[UA]


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77080/new/

https://reviews.llvm.org/D77080





More information about the llvm-commits mailing list