[PATCH] D76864: [mlir] StandardToLLVM: make one-to-one convresion pattern publicly available

[Alex Zinenko via Phabricator via llvm-commits]

ftynse marked an inline comment as done.
ftynse added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:1317
 };
 struct SelectOpLowering
+    : public OneToOneConvertToLLVMPattern<SelectOp, LLVM::SelectOp> {
----------------
rriddle wrote:
> nit: I forgot to mention a while ago, but all of these should really just be using directives; e.g.
> 
> using SelectOpLowering = OneToOneConvert...;
Good point! Done in c16c07d4b9adb43065f875176701f9a1f6e67a5e


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76864/new/

https://reviews.llvm.org/D76864