[PATCH] D76864: [mlir] StandardToLLVM: make one-to-one convresion pattern publicly available

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 11:22:59 PDT 2020


rriddle added inline comments.


================
Comment at: mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp:1317
 };
 struct SelectOpLowering
+    : public OneToOneConvertToLLVMPattern<SelectOp, LLVM::SelectOp> {
----------------
nit: I forgot to mention a while ago, but all of these should really just be using directives; e.g.

using SelectOpLowering = OneToOneConvert...;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76864/new/

https://reviews.llvm.org/D76864





More information about the llvm-commits mailing list