[PATCH] D76844: [InstCombine] try to reduce shuffle with bitcasted operand

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added a subscriber: efriedma.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1944
+    if (auto *V = SimplifyShuffleVectorInst(X, UndefValue::get(XType),
+                                            ConstantVector::get(ScaledMaskC),
+                                            XType, SQ.getWithInstruction(&SVI)))
----------------
RKSimon wrote:
> Its seems a pity to create a speculative ConstantVector like this - can we easily refactor SimplifyShuffleVectorInst to take ArrayRef<int> ?
The diffs we want are part of D72467.
@efriedma - is that patch held up on anything? We may not have settled on the scalable vector future, but changing the fixed vector implementation would make things easier for existing code today.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76844/new/

https://reviews.llvm.org/D76844