[PATCH] D76844: [InstCombine] try to reduce shuffle with bitcasted operand

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 07:34:01 PDT 2020


RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineVectorOps.cpp:1944
+    if (auto *V = SimplifyShuffleVectorInst(X, UndefValue::get(XType),
+                                            ConstantVector::get(ScaledMaskC),
+                                            XType, SQ.getWithInstruction(&SVI)))
----------------
Its seems a pity to create a speculative ConstantVector like this - can we easily refactor SimplifyShuffleVectorInst to take ArrayRef<int> ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76844/new/

https://reviews.llvm.org/D76844





More information about the llvm-commits mailing list