[PATCH] D76746: [MC][ARM] Make .reloc support arbitrary relocation types

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 02:40:47 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/MC/ARM/reloc-directive-err.s:1
+# RUN: llvm-mc -triple=armv7 %s 2>&1 | FileCheck --check-prefix=PRINT %s
+# RUN: not llvm-mc -filetype=obj -triple=armv7 %s -o /dev/null 2>&1 | FileCheck %s
----------------
grimar wrote:
> Should this test be `MC/ARM` and use `-triple=armv7`? Could it be a generic test?
I mean `R_INVALID` looks like it is a generic invalid relocation and I'd expect to have a generic test for "unknown relocation name" message.
I am not an expert in llvm-mc though, perhaps I am missing something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76746/new/

https://reviews.llvm.org/D76746





More information about the llvm-commits mailing list