[PATCH] D76746: [MC][ARM] Make .reloc support arbitrary relocation types

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp:182
 
+  if (Kind >= FirstLiteralRelocationKind)
+    return MCAsmBackend::getFixupKindInfo(FK_NONE);
----------------
Deserves a comment I think.


================
Comment at: llvm/test/MC/ARM/reloc-directive-err.s:1
+# RUN: llvm-mc -triple=armv7 %s 2>&1 | FileCheck --check-prefix=PRINT %s
+# RUN: not llvm-mc -filetype=obj -triple=armv7 %s -o /dev/null 2>&1 | FileCheck %s
----------------
Should this test be `MC/ARM` and use `-triple=armv7`? Could it be a generic test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76746/new/

https://reviews.llvm.org/D76746