[PATCH] D76199: GlobalISel: Fix round lowering

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 07:35:33 PDT 2020


foad accepted this revision.
foad added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:4691
   // result = trunc(src);
   // if (src < 0.0 && src != result)
   //   result += -1.0.
----------------
Not related to your patch, but couldn't this be `if (result > src)` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76199/new/

https://reviews.llvm.org/D76199





More information about the llvm-commits mailing list