[PATCH] D76199: GlobalISel: Fix round lowering

Serge Pavlov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 16 07:35:32 PDT 2020


sepavloff added a comment.

I looked through the implementation of `lowerIntrinsicRound`, it looks good for me.



================
Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-intrinsic-round.mir:1
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
 # RUN: llc -mtriple=amdgcn-mesa-mesa3d -mcpu=tahiti -run-pass=legalizer %s -o - | FileCheck -check-prefix=GFX6 %s
----------------
If the previous version of this file tested intrinsic `floor`, maybe it makes sense to keep that version (with necessary changes) under a new name, to keep tests for `floor`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76199/new/

https://reviews.llvm.org/D76199





More information about the llvm-commits mailing list