[PATCH] D76124: [TTI] Remove getOperationCost

[Sam Parker via Phabricator via llvm-commits]

samparker updated this revision to Diff 250216.
samparker added a comment.

Ah, I love reminding myself why I don't like working in this area... I still can't figure out why we need TTIImpl, BasicTTIImpl, TargetLoweringInfo and then the target-specific TTIs too, and worse, why the generic parts seem to produce different results given the same values! So the code in TargetTransformInfoImpl still needs to try to special-case int/ptr conversions (instead of BasicTTI), as well as sext/zext because of the interactions with the inline cost model... I'd welcome some education of the hows and whys of these layers! Anyway, the int/ptr conversion costs are back to their original values.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76124/new/

https://reviews.llvm.org/D76124

Files:
  llvm/include/llvm/Analysis/TargetTransformInfo.h
  llvm/include/llvm/Analysis/TargetTransformInfoImpl.h
  llvm/include/llvm/CodeGen/BasicTTIImpl.h
  llvm/lib/Analysis/TargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/SystemZ/ext-of-icmp-cost.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76124.250216.patch
Type: text/x-patch
Size: 15828 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200313/beacaf39/attachment.bin>