[PATCH] D76124: [TTI] Remove getOperationCost

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 13 05:46:15 PDT 2020


samparker marked an inline comment as done.
samparker added inline comments.


================
Comment at: llvm/include/llvm/Analysis/TargetTransformInfoImpl.h:92
-      // the pointer, and a legal integer type.
-      unsigned DestSize = Ty->getScalarSizeInBits();
-      if (DL.isLegalInteger(DestSize) &&
----------------
dmgreen wrote:
> This code is missing now?
> 
> Or at least the IntToPtr code was copied over, the PtrToInt wasn't and has become a cast.
Ah, I was intending to merge all the casts and so I've actually missed IntToPtr. This almost certainly the reason for the change, so I'll have a look at the default costs of casts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76124/new/

https://reviews.llvm.org/D76124





More information about the llvm-commits mailing list