[PATCH] D75954: Cache uwnind frame headers as they are found.

[Mikael Holmén via llvm-commits]

Hi,

I still got the warnings with this fix so I pushed something in
abc238a3c7361 that at least makes the compiler quiet when i build.

Please take a look and see if that's reasonable or if that fix should
be reverted.

/Mikael

On Thu, 2020-03-12 at 18:18 -0700, Sterling Augustine via llvm-commits
wrote:
> Should be fixed by 3758b858ef3b39b3081bf9a567ead8bc69c9a208.
> 
> But because I can't test the build, I can't verify.
> 
> On Thu, Mar 12, 2020 at 5:42 PM Sterling Augustine <
> saugustine at google.com> wrote:
> > I will fix.
> > 
> > On Thu, Mar 12, 2020 at 3:45 PM Vlad Vereschaka via Phabricator <
> > reviews at reviews.llvm.org> wrote:
> > > vvereschaka added a comment.
> > > 
> > > Hello @saugustine,
> > > 
> > > here is failed libunwind test on Aarch64 toolchain builder
> > > 
http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5660
> > > 
> > > - FAIL: libunwind:: frameheadercache_test.pass.cpp
> > > 
> > > with a set of similar errors:
> > > 
> > >   C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-
> > > project\libunwind\test/../src/Registers.hpp:3158:59: error:
> > > unused parameter 'regNum' [-Werror,-Wunused-parameter]
> > > 
> > >   inline bool Registers_mips_newabi::validFloatRegister(int
> > > regNum) const {
> > > 
> > > would you take care of it?
> > > 
> > > 
> > > Repository:
> > >   rG LLVM Github Monorepo
> > > 
> > > CHANGES SINCE LAST ACTION
> > >   https://reviews.llvm.org/D75954/new/
> > > 
> > > https://reviews.llvm.org/D75954
> > > 
> > > 
> > > 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> 
https://protect2.fireeye.com/v1/url?k=f22a25f0-aea0f0e6-f22a656b-862f14a9365e-3d839ca728c3c5be&q=1&e=eb012d65-544d-40b3-a81e-577ee1b91493&u=https%3A%2F%2Flists.llvm.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fllvm-commits