[PATCH] D75954: Cache uwnind frame headers as they are found.

Sterling Augustine via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 12 18:18:00 PDT 2020


Should be fixed by 3758b858ef3b39b3081bf9a567ead8bc69c9a208.

But because I can't test the build, I can't verify.

On Thu, Mar 12, 2020 at 5:42 PM Sterling Augustine <saugustine at google.com>
wrote:

> I will fix.
>
> On Thu, Mar 12, 2020 at 3:45 PM Vlad Vereschaka via Phabricator <
> reviews at reviews.llvm.org> wrote:
>
>> vvereschaka added a comment.
>>
>> Hello @saugustine,
>>
>> here is failed libunwind test on Aarch64 toolchain builder
>> http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/5660
>>
>> - FAIL: libunwind:: frameheadercache_test.pass.cpp
>>
>> with a set of similar errors:
>>
>>
>> C:\buildbot\as-builder-2\llvm-clang-win-x-aarch64\llvm-project\libunwind\test/../src/Registers.hpp:3158:59:
>> error: unused parameter 'regNum' [-Werror,-Wunused-parameter]
>>
>>   inline bool Registers_mips_newabi::validFloatRegister(int regNum) const
>> {
>>
>> would you take care of it?
>>
>>
>> Repository:
>>   rG LLVM Github Monorepo
>>
>> CHANGES SINCE LAST ACTION
>>   https://reviews.llvm.org/D75954/new/
>>
>> https://reviews.llvm.org/D75954
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200312/5edbc2db/attachment.html>


More information about the llvm-commits mailing list