[PATCH] D75695: [StackProtector] Catch direct out-of-bounds when checking address-takenness

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D75695#1914314 <https://reviews.llvm.org/D75695#1914314>, @john.brawn wrote:

> In D75695#1912905 <https://reviews.llvm.org/D75695#1912905>, @probinson wrote:
>
> > Changes look good, but there's still the question about whether you really need the loop tests.
>
>
> I think I originally added these because of a previous attempt at a fix, which was more complicated (in a way that didn't improve anything) and did at one point have a problem with loops. I could remove them, though I don't see much reason to. I will if you really want though.


Project practice is to try to have regression tests that are fairly focused, and don't contain any extraneous or redundant cases.  This helps future devs trying to read and understand your test.  It also reduces testing time by an admittedly small increment, but when you add up those increments across 10s of Ks of tests and N-hundred developers running them many many times per day, it adds up.
There's a place for more thorough testing, IMO, but that place is not the `lit` tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75695/new/

https://reviews.llvm.org/D75695