[PATCH] D75695: [StackProtector] Catch direct out-of-bounds when checking address-takenness

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 05:48:46 PDT 2020


john.brawn added a comment.

In D75695#1912905 <https://reviews.llvm.org/D75695#1912905>, @probinson wrote:

> Changes look good, but there's still the question about whether you really need the loop tests.


I think I originally added these because of a previous attempt at a fix, which was more complicated (in a way that didn't improve anything) and did at one point have a problem with loops. I could remove them, though I don't see much reason to. I will if you really want though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75695/new/

https://reviews.llvm.org/D75695





More information about the llvm-commits mailing list