[PATCH] D75819: [PowerPC][NFC] Rename instruction formats in PPCInstrPrefix.td

[Lei Huang via Phabricator via llvm-commits]

lei accepted this revision.
lei added a comment.
This revision is now accepted and ready to land.

Just 1 minor name change.  Otherwise LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:46
 
-class MLS_DForm_R_D34_RTA5<bits<6> opcode, dag OOL, dag IOL, string asmstr,
-                           InstrItinClass itin, list<dag> pattern>
+class MLS_DForm_R_SI34_FRS5<bits<6> opcode, dag OOL, dag IOL, string asmstr,
+                            InstrItinClass itin, list<dag> pattern>
----------------
amyk wrote:
> Note that I've changed this format to have `SI34_FRS5`. I was originally going to change just `D34` to `SI34` but then the instruction format name would be `MLS_DForm_R_SI34_RTA5`. This would not be possible, as there already exists an instruction format with this name (below the current instruction format).
Based on the other names, I think this should be `MLS_DForm_R_SI34_FRSA5` since D_RA is 34 bits immediate + 5 bit register field RA.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75819/new/

https://reviews.llvm.org/D75819