[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Tue Mar 10 06:27:00 PDT 2020

avl added inline comments.

================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:451
+    if (!ExpectedMacro)
+      WithColor::defaultErrorHandler(ExpectedMacro.takeError());
+    else
----------------
There was a patch replacing usages of WithColor methods(for error reporting purposes) : 
https://reviews.llvm.org/D74481 . During that patch it was suggested to use error handlers from DIDumpOptions inside DWARFContext::dump. Please use it instead of WithColor:

DumpOpts.RecoverableErrorHandler(ExpectedMacro.takeError());

like it is already used at 589 line.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086