[PATCH] D73086: [WIP][DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 10 05:48:50 PDT 2020


SouraVX updated this revision to Diff 249330.
SouraVX added a comment.

Addressed @Ikudrin comments, Thanks a lot for this!
-Error handling switched to Expected based. Replaced `RecoverableErrorHandler` with `defaultErrorHandler` since we're not `dumping` anything in case of Error encountered during parsing `Header`.
-Removed redundancy from test case, reduced to minimal `macro/macinfo/str` section and relevant content verification.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/include/llvm/DebugInfo/DWARF/DWARFObject.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macro-macinfo.s
  llvm/test/DebugInfo/X86/debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-dwarf64-debug-macro-v5.s
  llvm/test/DebugInfo/X86/unsupported-opcode_operands_table-debug-macro-v5.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73086.249330.patch
Type: text/x-patch
Size: 22803 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200310/8690da7f/attachment.bin>


More information about the llvm-commits mailing list