[PATCH] D74176: [CMake] Link against ZLIB::ZLIB

[Thomas Preud'homme via llvm-commits]

Thanks for the reply, I'll try to follow but I'm not sure I'll be of much help as I'm quite new to CMake.

Best regards,

Thomas
________________________________
From: llvm-commits <llvm-commits-bounces at lists.llvm.org> on behalf of Wenlei He via Phabricator via llvm-commits <llvm-commits at lists.llvm.org>
Sent: 03 March 2020 23:33
To: phosek at google.com <phosek at google.com>; compnerd at compnerd.org <compnerd at compnerd.org>; smeenai at fb.com <smeenai at fb.com>
Cc: aktoon at gmail.com <aktoon at gmail.com>; hiraditya at msn.com <hiraditya at msn.com>; zturner at roblox.com <zturner at roblox.com>; llvm-commits at lists.llvm.org <llvm-commits at lists.llvm.org>
Subject: [PATCH] D74176: [CMake] Link against ZLIB::ZLIB

     [This message was sent from somebody outside of your organisation]



wenlei added a comment.

This change broke our use of LLVMSupport library, and I also noticed it's been reverted already.

It was previously broken even without this patch, and we had to hack/patch it internally to make it work for our use case. Here's what we had internally: https://reviews.llvm.org/D72490. It's not landed, but there's some discussion about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74176/new/

https://reviews.llvm.org/D74176



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200304/3a7ff127/attachment.html>