<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks for the reply, I'll try to follow but I'm not sure I'll be of much help as I'm quite new to CMake.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Best regards,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thomas<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> llvm-commits <llvm-commits-bounces@lists.llvm.org> on behalf of Wenlei He via Phabricator via llvm-commits <llvm-commits@lists.llvm.org><br>
<b>Sent:</b> 03 March 2020 23:33<br>
<b>To:</b> phosek@google.com <phosek@google.com>; compnerd@compnerd.org <compnerd@compnerd.org>; smeenai@fb.com <smeenai@fb.com><br>
<b>Cc:</b> aktoon@gmail.com <aktoon@gmail.com>; hiraditya@msn.com <hiraditya@msn.com>; zturner@roblox.com <zturner@roblox.com>; llvm-commits@lists.llvm.org <llvm-commits@lists.llvm.org><br>
<b>Subject:</b> [PATCH] D74176: [CMake] Link against ZLIB::ZLIB</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText"> [This message was sent from somebody outside of your organisation]<br>
<br>
<br>
<br>
wenlei added a comment.<br>
<br>
This change broke our use of LLVMSupport library, and I also noticed it's been reverted already.<br>
<br>
It was previously broken even without this patch, and we had to hack/patch it internally to make it work for our use case. Here's what we had internally:
<a href="https://reviews.llvm.org/D72490">https://reviews.llvm.org/D72490</a>. It's not landed, but there's some discussion about this.<br>
<br>
<br>
Repository:<br>
rG LLVM Github Monorepo<br>
<br>
CHANGES SINCE LAST ACTION<br>
<a href="https://reviews.llvm.org/D74176/new/">https://reviews.llvm.org/D74176/new/</a><br>
<br>
<a href="https://reviews.llvm.org/D74176">https://reviews.llvm.org/D74176</a><br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
llvm-commits@lists.llvm.org<br>
<a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div>
</span></font></div>
</body>
</html>