[PATCH] D75371: [ARM] Optimise ASRL/LSRL to smaller shifts using demand bits.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 02:20:27 PST 2020


samparker added a comment.

Are there tests for shifts greater than 31? And don't we do some weird stuff with negative shifts, or is that just with custom nodes?



================
Comment at: llvm/lib/Target/ARM/ARMISelLowering.h:358
+                                           TargetLoweringOpt &TLO,
+                                           unsigned Depth) const;
+
----------------
Doesn't this need override?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75371/new/

https://reviews.llvm.org/D75371





More information about the llvm-commits mailing list