[PATCH] D75536: [LLD] Add support for --unique option

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 4 01:13:21 PST 2020


jhenderson added inline comments.


================
Comment at: lld/ELF/Options.td:377
 
+
+def unique: F<"unique">, HelpText<"Creates a separate output section for every orphan input section">;
----------------
Nit: too many blank lines here.


================
Comment at: lld/test/ELF/unique-orphans.s:13
+
+# We should have 2 instance of orphan section .text.foo
+# RUN: ld.lld %t.o -r -o %t.ro --unique
----------------
instance -> instances (here and below)


================
Comment at: lld/test/ELF/unique-orphans.s:30
+# UNIQUE_SCRIPT-NOT: .foo
\ No newline at end of file

----------------
Nit: no newline at EOF.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536





More information about the llvm-commits mailing list