[PATCH] D75536: [LLD] Add support for --unique option

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: lld/test/ELF/unique-orphans.s:13
+
+# We should have 2 instance of orphan section .text.foo
+# RUN: ld.lld %t.o -r -o %t.ro --unique
----------------
jhenderson wrote:
> instance -> instances (here and below)
Consider using `##` for comments. It is a modern common way.


================
Comment at: lld/test/ELF/unique-orphans.s:17
+# UNIQUE_R-COUNT-3: .foo
+# UNIQUE_R-NOT: .foo
+
----------------
Seems you can have a single chack block:

```
# CHECK-3:   .foo
# CHECK-NOT: .foo
```

And remove `--check-prefix` from everywhere?


================
Comment at: lld/test/ELF/unique-orphans.s:19
+
+# We should have 2 instance of orphan section .text.foo
+# RUN: ld.lld %t.o -o %t.elf --unique 
----------------
`.text.foo` -> `.foo`? (and above)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75536/new/

https://reviews.llvm.org/D75536