[PATCH] D75338: [Coroutines] Use dbg.declare for frame variables

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 14:24:41 PST 2020


modocache added inline comments.


================
Comment at: llvm/lib/Transforms/Coroutines/CoroFrame.cpp:793-796
+    SmallVector<DbgVariableIntrinsic *, 2> DbgUsers;
+    findDbgUsers(DbgUsers, A);
+    for (auto *DI : DbgUsers)
+      DI->eraseFromParent();
----------------
jmorse wrote:
> This should now be redundant and removed, as replaceDbgUsesWithUndef should have undef'd all debug users.
Oops! I'd missed this and accidentally left it in. Thanks for catching! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75338/new/

https://reviews.llvm.org/D75338





More information about the llvm-commits mailing list