[PATCH] D75338: [Coroutines] Use dbg.declare for frame variables

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 3 14:24:40 PST 2020


modocache updated this revision to Diff 248029.
modocache marked 7 inline comments as done.
modocache added a comment.

Thanks again for the review. I moved `findDbgDeclareUses` to `Local.h` (no unittest for now but I'll add one in a follow-up diff for both it and `FindDbgAddrUses`, which doesn't have one either) and I removed the redundant loop. I'll commit this now and add an lldb regression test in a follow-up patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75338/new/

https://reviews.llvm.org/D75338

Files:
  llvm/include/llvm/Transforms/Utils/Local.h
  llvm/lib/Transforms/Coroutines/CoroFrame.cpp
  llvm/lib/Transforms/Utils/Local.cpp
  llvm/test/Transforms/Coroutines/coro-debug-frame-variable.ll
  llvm/test/Transforms/Coroutines/coro-debug.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75338.248029.patch
Type: text/x-patch
Size: 18402 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200303/ce807111/attachment.bin>


More information about the llvm-commits mailing list