[llvm] 30dae38 - Fix LLP64 detection in SwapByteOrder.h

[Reid Kleckner via llvm-commits]

On Wed, Feb 26, 2020 at 1:53 PM Joerg Sonnenberger <joerg at bec.de> wrote:

> On Wed, Feb 26, 2020 at 10:59:52AM -0800, Reid Kleckner via llvm-commits
> wrote:
> >
> > Author: Reid Kleckner
> > Date: 2020-02-26T10:59:45-08:00
> > New Revision: 30dae38349cbe293bee0705b313dc747e53afd49
> >
> > URL:
> https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49
> > DIFF:
> https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49.diff
> >
> > LOG: Fix LLP64 detection in SwapByteOrder.h
>
> Why not include limits.h instead and just use the regular size macros?
>

It seemed more likely to cause breakage. The ifdefs in DataTypes.h suggest
there is some risk:
https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm-c/DataTypes.h#L38
And in general, less ifdefs -> better.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200226/946f87db/attachment.html>