<div dir="ltr"><div dir="ltr">On Wed, Feb 26, 2020 at 1:53 PM Joerg Sonnenberger <<a href="mailto:joerg@bec.de">joerg@bec.de</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Feb 26, 2020 at 10:59:52AM -0800, Reid Kleckner via llvm-commits wrote:<br>
> <br>
> Author: Reid Kleckner<br>
> Date: 2020-02-26T10:59:45-08:00<br>
> New Revision: 30dae38349cbe293bee0705b313dc747e53afd49<br>
> <br>
> URL: <a href="https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49</a><br>
> DIFF: <a href="https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49.diff" rel="noreferrer" target="_blank">https://github.com/llvm/llvm-project/commit/30dae38349cbe293bee0705b313dc747e53afd49.diff</a><br>
> <br>
> LOG: Fix LLP64 detection in SwapByteOrder.h<br>
<br>
Why not include limits.h instead and just use the regular size macros?<br></blockquote><div><br></div><div>It seemed more likely to cause breakage. The ifdefs in DataTypes.h suggest there is some risk:</div><div><a href="https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm-c/DataTypes.h#L38">https://github.com/llvm/llvm-project/blob/master/llvm/include/llvm-c/DataTypes.h#L38</a></div><div>And in general, less ifdefs -> better.<br></div></div></div>