[PATCH] D65593: [Attributor] Deduction based on path exploration

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Thanks for resurrecting this patch. This gives us really interesting opportunities as we can already see with the nonnull and deref changes :)
I will need to look over everything, maybe next week (I'm on travel again). A first comment inlined though.



================
Comment at: llvm/include/llvm/Analysis/MustExecute.h:473
+        Instructions.push_back(*EIt);
+  }
+
----------------
My first impression is that we might want to shift the burden of collecting instructions to the user and just do the iterating here. The benefit is that we could use the return of `Pred` to indicate that we want to stop. I think we want to have a way to stop the search of the context if we don't expect to find better results anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65593/new/

https://reviews.llvm.org/D65593