[PATCH] D65593: [Attributor] Deduction based on path exploration

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 10:20:54 PST 2020


baziotis added a comment.

That's very interesting, I hope I'll have time to come back with a better review.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1050-1051
+
+        SetVector<const Use *> UsesInChild = Uses;
+        followUsesInContext(A, Explorer, &BB->front(), UsesInChild, ChildState);
+
----------------
This `UsesInChild` I think is not used anywhere. Probably put there since something has to be passed to the function. Can we do something to avoid inserting to it and deleting in every loop? (If I haven't missed something)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65593/new/

https://reviews.llvm.org/D65593





More information about the llvm-commits mailing list