[PATCH] D75035: [AArch64][SVE] Refactor the implementation of gathers/scatters (NFC)

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 13:16:13 PST 2020


sdesmalen added a comment.

nit: The title suggests that this patch refactors the entire implementation of gather/scatter, where it's mostly a few name changes to the ACLE intrinsics and updated comments.



================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:12617
 
+  // For FPs, ACLE only supports _packed_ single and double precision types.
+  if (RetElVT.isFloatingPoint())
----------------
This is not a non-functional change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75035/new/

https://reviews.llvm.org/D75035





More information about the llvm-commits mailing list