[PATCH] D74368: [TBLGEN] Fix subreg value overflow in DAGISelMatcher

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 10:12:18 PST 2020


rampitec marked an inline comment as done.
rampitec added inline comments.


================
Comment at: llvm/utils/TableGen/RegisterInfoEmitter.cpp:176
       OS << "namespace " << Namespace << " {\n";
-    OS << "enum {\n  NoSubRegister,\n";
+    OS << "enum : uint16_t {\n  NoSubRegister,\n";
     unsigned i = 0;
----------------
bcain wrote:
> Is it expected that the context for this .inc should have already included `<cstdint>` or that tablegen should be emitting that include in order to use this type?
That is produced by the tablegen in many different places, so I assume it should be already defined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74368/new/

https://reviews.llvm.org/D74368





More information about the llvm-commits mailing list